Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xray] Fix containerSecurityContext with loggers in StatefulState template #1837

Closed
wants to merge 3 commits into from

Conversation

jbblache
Copy link

@jbblache jbblache commented Nov 3, 2023

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Fix containerSecurityContext on loggers since we are in a range. The .Values.containerSecurityContext.enabled is not found and replaced. The "$" fixes the problem.

Special notes for your reviewer:

Copy link

github-actions bot commented Nov 3, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jbblache
Copy link
Author

jbblache commented Nov 3, 2023

I have read the CLA Document and I hereby sign the CLA

@rahulsadanandan
Copy link
Collaborator

@jbblache Thank you for the pull request. We've incorporated it internally and it will roll out with the 3.86.x versions of xray.

@oumkale
Copy link
Member

oumkale commented Aug 2, 2024

Hi @jbblache,

Kudos to you, Thank you so much for this PR.

We have released this in Xray version 3.86.1.

@oumkale oumkale closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants