Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[artifactory] resource constraints for "setup" initContainer of nginx deployment #1866

Conversation

andrewrothstein
Copy link

@andrewrothstein andrewrothstein commented Mar 20, 2024

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:
my cluster requires resource constraints on all containers

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

fixes #962

Special notes for your reviewer:

Copy link

github-actions bot commented Mar 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@andrewrothstein
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@andrewrothstein andrewrothstein force-pushed the feature/artifactory-nginx-init-resources branch from ba3935e to b327e8f Compare May 5, 2024 20:07
@andrewrothstein
Copy link
Author

Is there anyone out there?

@RobinDuhan
Copy link

Thanks for the PR, Andrew. We are checking, and will be taking this in next patch and it will be available in next couple of weeks, 784.x.

@oumkale
Copy link
Member

oumkale commented Aug 2, 2024

Hi @andrewrothstein,

Kudos to you, Thank you so much for this PR.

We have released this in Artifactory version 7.84.14.

@oumkale oumkale closed this Aug 2, 2024
@oumkale oumkale self-requested a review August 2, 2024 05:49
@andrewrothstein andrewrothstein deleted the feature/artifactory-nginx-init-resources branch October 21, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of specifying resources for initContainers in nginx deployment and Artifactory statefulset
3 participants