Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maven-artifactory-plugin.md #149

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update maven-artifactory-plugin.md #149

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e13d57d
Update maven-artifactory-plugin.md
vladdoster Aug 18, 2024
27e5805
Update maven-artifactory-plugin.md
vladdoster Aug 18, 2024
b555ec9
Merge branch 'main' into patch-2
vladdoster Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions jfrog-applications/ci-and-sdks/ci-integrations/maven-artifactory-plugin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ A typical build plugin configuration would be as follows:
</build>
```

The plugin's invocation phase is validate by default, and we recommend you don't change it so the plugin is called as early as possible in the lifecycle of your Maven build.
The plugin's invocation phase is validated by default, and we recommend you don't change it so the plugin is called as early as possible in the lifecycle of your Maven build.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The invitation phase is called "Validate". Perhaps it is best to make Validate a link to a Maven document describing the lifecycle phrases, to make it clearer this isn't a phrasing problem.


#### Full Configuration

The example above configures the Artifactory publisher, to deploy build artifacts either to the releases or the snapshots repository of Artifactory when `mvn deploy` is executed.
The example above configures the Artifactory publisher to deploy and build artifacts either to the releases or the snapshots repository of Artifactory when `mvn deploy` is executed.

However, the Maven Artifactory Plugin provides many other configurations:

Expand Down Expand Up @@ -98,9 +98,9 @@ However, the Maven Artifactory Plugin provides many other configurations:
<excludePatterns>..</excludePatterns>
<includePatterns>..</includePatterns>
<filterExcludedArtifactsFromBuild>true/false</filterExcludedArtifactsFromBuild>
<!-- If true build information published to Artifactory will include implicit project as well as build-time dependencies -->
<!-- If true build information published to Artifactory will include the implicit project as well as build-time dependencies -->
<recordAllDependencies>true/false</recordAllDependencies>
<!-- Minimum file size in KB for which the plugin performs checksum deploy optimization. Default: 10. Set to 0 to disable uploading files with checksum that already exists in Artifactory. -->
<!-- Minimum file size in KB for which the plugin performs checksum deploy optimization. Default: 10. Set to 0 to disable uploading files with the checksum that already exists in Artifactory. -->
<minChecksumDeploySizeKb>10</minChecksumDeploySizeKb>
</publisher>
<proxy>
Expand All @@ -118,13 +118,13 @@ However, the Maven Artifactory Plugin provides many other configurations:
|:--------------------:|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `<deployProperties>` | Specifies properties you can attach to published artifacts. For example: prop-value. |
| `<artifactory>` | Specifies whether environment variables are published as part of BuildInfo metadata and which include or exclude patterns are applied when variables are collected |
| `<publisher>` | Defines an Artifactory repository where build artifacts should be published using a combination of a `<contextUrl>` and `<repoKey>/<snapshotRepoKey>`. Build artifacts are deployed if the deploy goal is executed and only after all modules are built. |
| `<publisher>` | Defines an Artifactory repository where build artifacts should be published using a combination of a `<contextUrl>` and `<repoKey>/<snapshotRepoKey>`. Build artifacts are deployed only after the deployment goal is executed and all modules are built. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is called "deploy" and therefore it shouldn't be referenced as "the deployment goal".

| `<buildInfo>` | Updates BuildInfo metadata published together with build artifacts. You can configure whether or not BuildInfo metadata is published using the configuration. |
| `<proxy>` | Specifies HTTP/S proxy. |

#### Reading Environment Variables and System Properties

Every build server provides its own set of environment variables. You can utilize these variables when configuring the plugin as shown in the following example:
Every build server provides its own set of environment variables. You can utilize these variables when configuring the plugin, as shown in the following example:

```xml

Expand Down
Loading