Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable conan support #781

Merged
merged 19 commits into from
Jan 6, 2025
Merged

Enable conan support #781

merged 19 commits into from
Jan 6, 2025

Conversation

orto17
Copy link
Contributor

@orto17 orto17 commented Nov 6, 2024 •
edited
Loading

This PR includes support of conan requirements file update. It does not support installation of the suggested fixes. In order to update the dependencies, the user should run a 'conan install' command with the suggested conan file..

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

@orto17 orto17 added the safe to test Approve running integration tests on a pull request label Nov 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 6, 2024
@orto17 orto17 added the safe to test Approve running integration tests on a pull request label Nov 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 6, 2024
@orto17 orto17 added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@orto17 orto17 added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
eranturgeman
eranturgeman requested changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Most of the comments are "cosmetics" and things we talked about that we can further discuss

@orto17 orto17 added the safe to test Approve running integration tests on a pull request label Dec 1, 2024
@orto17 orto17 added the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@orto17 orto17 added the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

@orto17 orto17 force-pushed the enable-conan-support branch from aa9d487 to 91c07fd Compare January 6, 2025 08:31
@orto17 orto17 merged commit b1d7115 into jfrog:dev Jan 6, 2025
5 of 6 checks passed
@attiasas attiasas added new feature Automatically generated release notes improvement Automatically generated release notes and removed new feature Automatically generated release notes labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranturgeman eranturgeman eranturgeman approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orto17 @eranturgeman @attiasas