-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JAS violations #788
Open
attiasas
wants to merge
39
commits into
jfrog:dev
Choose a base branch
from
attiasas:jas_violations
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add JAS violations #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Nov 26, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Nov 26, 2024
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Nov 26, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Nov 26, 2024
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 3, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 3, 2024
if v, ok := codeFlows[info.RuleId]; ok { | ||
scannerCodeFlows = v | ||
} | ||
if len(rulesInfo) == 1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we create a one table if len(rulesInfo)==1 and a different one when not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Jan 2, 2025
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jan 2, 2025
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Jan 2, 2025
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jan 2, 2025
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Jan 2, 2025
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Adding JAS Violation Support
JF_INCLUDE_VULNERABILITIES
to include vulnerabilities ifJF_PROJECT
/JF_WATCHES
is defined or if there areGit Repository
watches defined at the platform.git repo key
as their resource at the platforms, you will no longer get vulnerabilities only if you added theJF_INCLUDE_VULNERABILITIES
variablesAdding JAS violation results and improving Issue Details
Improve the Issue display and add a bit more information in the comment
Adding Scan Summary