Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JAS violations #788

Open
wants to merge 39 commits into
base: dev
Choose a base branch
from
Open

Add JAS violations #788

wants to merge 39 commits into from

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 25, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Depends on:

Adding JAS Violation Support

  • From now on, Frogbot is capable of generating both violations and vulnerabilities at the same scan. pass the environment variable JF_INCLUDE_VULNERABILITIES to include vulnerabilities if JF_PROJECT / JF_WATCHES is defined or if there are Git Repository watches defined at the platform.
  • If you define watches with git repo key as their resource at the platforms, you will no longer get vulnerabilities only if you added the JF_INCLUDE_VULNERABILITIES variables

Adding JAS violation results and improving Issue Details

image

image

Improve the Issue display and add a bit more information in the comment

image

Adding Scan Summary

image

@attiasas attiasas added the new feature Automatically generated release notes label Nov 25, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 26, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 26, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 3, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 3, 2024
if v, ok := codeFlows[info.RuleId]; ok {
scannerCodeFlows = v
}
if len(rulesInfo) == 1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we create a one table if len(rulesInfo)==1 and a different one when not?

utils/params.go Outdated Show resolved Hide resolved
utils/scandetails.go Outdated Show resolved Hide resolved
Copy link
Contributor

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 2, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 2, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 2, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 2, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 2, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants