Skip to content

Commit

Permalink
update deps
Browse files Browse the repository at this point in the history
  • Loading branch information
sverdlov93 committed Jan 18, 2024
1 parent 1629c8d commit f4362f5
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 22 deletions.
35 changes: 17 additions & 18 deletions .github/workflows/analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,37 +7,36 @@ on:
- "**"
pull_request:
jobs:
go-analysis:
Static-Check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Checkout Source
uses: actions/checkout@v3

- name: Setup Go
uses: actions/setup-go@v5
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: 1.20.x
cache: false

- name: Static Code Analysis
uses: golangci/golangci-lint-action@v3
with:
args: |
--timeout 5m --out-${NO_FUTURE}format colored-line-number --enable gosec,errcheck,gosimple,govet,ineffassign,staticcheck,typecheck,unused,gocritic,asasalint,asciicheck,errchkjson,exportloopref,forcetypeassert,makezero,nilerr,unparam,unconvert,wastedassign,usestdlibvars
--timeout 5m --out-${NO_FUTURE}format colored-line-number --enable errcheck,gosimple,govet,ineffassign,staticcheck,typecheck,unused,gocritic,asasalint,asciicheck,errchkjson,exportloopref,forcetypeassert,makezero,nilerr,unparam,unconvert,wastedassign,usestdlibvars
bash-analysis:
Go-Sec:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Checkout Source
uses: actions/checkout@v3

- name: Run ShellCheck
uses: ludeeus/action-shellcheck@master
- name: Install Go
uses: actions/setup-go@v3
with:
ignore_paths: "*test*"

check-spelling:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
go-version: 1.20.x

- name: Check spelling
uses: crate-ci/typos@master
- name: Run Gosec Security Scanner
uses: securego/gosec@v2
with:
args: -exclude G204,G301,G302,G304,G306 -tests -exclude-dir \.*test\.* ./...
8 changes: 4 additions & 4 deletions parallel/bounded_runner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,10 @@ func TestFailFastOnTaskError(t *testing.T) {
wg.Wait()
checkResult(expectedTotal, results, t)

//TODO: Fix this test
//This test is fragile since 1 or more goroutines may be executing and failing fast in parallel,
//calling the error handler and increasing the result. So we cannot use accurate comparison.
//Here we only take care of uo to 1 additional concurrent failfast.
// TODO: Fix this test
// This test is fragile since 1 or more goroutines may be executing and failing fast in parallel,
// calling the error handler and increasing the result. So we cannot use accurate comparison.
// Here we only take care of uo to 1 additional concurrent failfast.
errTotal := 0
for {
err := errorsQueue.GetError()
Expand Down

0 comments on commit f4362f5

Please sign in to comment.