Allow resetting the finish notification of a runner #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahavi
force-pushed
the
fix-finish-notification
branch
from
7f5373a
to
2527591
Compare
Merged
4 tasks
eyalbe4
approved these changes
Dec 22, 2023
eyalbe4
approved these changes
Dec 23, 2023
eyalbe4
added
new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency for jfrog/jfrog-cli-core#1086
Imagine this scenario: there are two runners, "One" and "Two". One assigns tasks to Two.
At times, Two might have no tasks. When this occurs, Two's finish notification could trigger prematurely.
To tackle this rare situation, this PR introduces an option to reset the finish notification. After One finishes its tasks, the user can reset Two's finish notification. This ensures that when we await Two's finish notification, we're fully covered.