Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set - make set from slice & add slice to set #45

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Set - make set from slice & add slice to set #45

merged 4 commits into from
Jan 8, 2024

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Jan 8, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • I labeled this pull request with one of the following: 'breaking change', 'new feature', 'bug', or 'ignore for release'

2 new APIs for gofrog generic set:

  • Make a new set from an existing slice
  • Add an existing slice to a set

@omerzi omerzi added the improvement Automatically generated release notes label Jan 8, 2024
@omerzi omerzi requested a review from yahavi January 8, 2024 09:31
@omerzi omerzi changed the base branch from master to dev January 8, 2024 09:31
@omerzi omerzi changed the title Create set from slice Set - make set from slice & add slice to set Jan 8, 2024
@omerzi omerzi added new feature Automatically generated release notes and removed improvement Automatically generated release notes labels Jan 8, 2024
@omerzi omerzi merged commit acbc58d into dev Jan 8, 2024
11 of 12 checks passed
@omerzi omerzi deleted the make-set-from-slice branch January 8, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerzi @yahavi