Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom split functions in createCommandReaders #62

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

gerrnot
Copy link

@gerrnot gerrnot commented Apr 17, 2024

Default is (still) split by line, but in some cases interesting command output spans multiple lines (e.g. commit messages)

This also provides a split function definition that splits by a string.

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • I labeled this pull request with one of the following: 'breaking change', 'new feature', 'bug', or 'ignore for release'
    ⓘ I would like to flag this as 'new feature' but I seem to lack permission!

Default is (still) split by line, but in some cases interesting command output spans multiple lines (e.g. commit messages)

This also provides a split function definition that splits by a string.
@gerrnot gerrnot changed the base branch from master to dev April 17, 2024 11:32
@gerrnot
Copy link
Author

gerrnot commented May 21, 2024

If somebody has a hint why frogbot is failing here I would be grateful. There i no output, just says it fails, but why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant