Support pipe and new line in the 'No proxy host'

jfrog · Sep 19, 2024 · b6e3157 · b6e3157
1 parent 411956b
commit b6e3157
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/main/java/io/jenkins/plugins/jfrog/CliEnvConfigurator.java b/src/main/java/io/jenkins/plugins/jfrog/CliEnvConfigurator.java
@@ -79,6 +79,7 @@ private static void excludeProxyEnvFromPublishing(EnvVars env) {
         String jfrogCliEnvExclude = env.getOrDefault(JFROG_CLI_ENV_EXCLUDE, JFROG_CLI_DEFAULT_EXCLUSIONS);
         env.put(JFROG_CLI_ENV_EXCLUDE, String.join(";", jfrogCliEnvExclude, HTTP_PROXY_ENV, HTTPS_PROXY_ENV));
     }
+
     /**
      * Converts a list of No Proxy Hosts received by Jenkins into a semicolon-separated string format expected by JFrog CLI.
      *

diff --git a/src/test/java/io/jenkins/plugins/jfrog/NoProxyExtractorTest.java b/src/test/java/io/jenkins/plugins/jfrog/NoProxyExtractorTest.java
@@ -7,7 +7,7 @@
 import java.util.Arrays;
 import java.util.Collection;
 
-import static io.jenkins.plugins.jfrog.CliEnvConfigurator.noProxyExtractor;
+import static io.jenkins.plugins.jfrog.CliEnvConfigurator.createNoProxyValue;
 import static org.junit.Assert.assertEquals;
 
 /**
@@ -42,6 +42,6 @@ public static Collection<Object[]> dataProvider() {
 
     @Test
     public void testNoProxyExtractor() {
-        assertEquals(expectedResult, noProxyExtractor(noProxyList));
+        assertEquals(expectedResult, createNoProxyValue(noProxyList));
     }
 }