try with closed resources

jfrog · Sep 12, 2024 · cea9c45 · cea9c45
1 parent 0bc0ff0
commit cea9c45
Showing 1 changed file with 14 additions and 13 deletions.
diff --git a/src/main/java/io/jenkins/plugins/jfrog/JfStep.java b/src/main/java/io/jenkins/plugins/jfrog/JfStep.java
@@ -329,19 +329,20 @@ Version getJfrogCliVersion(Launcher.ProcStarter launcher) throws IOException, In
         if (this.currentCliVersion != null) {
             return this.currentCliVersion;
         }
-        ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
-        ArgumentListBuilder builder = new ArgumentListBuilder();
-        builder.add(jfrogBinaryPath).add("-v");
-        int exitCode = launcher
-                .cmds(builder)
-                .pwd(launcher.pwd())
-                .stdout(outputStream)
-                .join();
-        if (exitCode != 0) {
-            throw new IOException("Failed to get JFrog CLI version: " + outputStream.toString(StandardCharsets.UTF_8));
+        try (ByteArrayOutputStream outputStream = new ByteArrayOutputStream()){
+            ArgumentListBuilder builder = new ArgumentListBuilder();
+            builder.add(jfrogBinaryPath).add("-v");
+            int exitCode = launcher
+                    .cmds(builder)
+                    .pwd(launcher.pwd())
+                    .stdout(outputStream)
+                    .join();
+            if (exitCode != 0) {
+                throw new IOException("Failed to get JFrog CLI version: " + outputStream.toString(StandardCharsets.UTF_8));
+            }
+            String versionOutput = outputStream.toString(StandardCharsets.UTF_8).trim();
+            String version = StringUtils.substringAfterLast(versionOutput, " ");
+            return new Version(version);
         }
-        String versionOutput = outputStream.toString(StandardCharsets.UTF_8).trim();
-        String version = StringUtils.substringAfterLast(versionOutput, " ");
-        return new Version(version);
     }
 }