Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Jenkins Security Scan #100

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Enable Jenkins Security Scan #100

merged 4 commits into from
Jul 23, 2024

Conversation

strangelookingnerd
Copy link

It is stated in the JENKINS SECURITY POLICY that

The Jenkins project takes security seriously. We make every possible effort to ensure users can adequately secure their automation infrastructure. To that end, we work with Jenkins core and plugin developers, as well as security researchers, to fix security vulnerabilities in Jenkins in a timely manner, and to improve the security of Jenkins in general.

We as plugin developers should try our best to support this. One way of doing so is to enable the Jenkins Security Scan on this repository. For more details see the documentation.

This PR may create new issues in the Code scanning section of this project once it is merged. I'd be happy to try and help resolve those if necessary.

Please note this PR was created semi-automatically. If you find any issue with it, don't hesitate to ping me.
For more details see the Jenkins Developers Google Group.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link

github-actions bot commented Jul 23, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@strangelookingnerd
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@yahavi yahavi added the ignore for release Automatically generated release notes label Jul 23, 2024
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for opening this pull request.
I'm concerned about having security-events: write with the pull_request trigger, as it makes this repository vulnerable to security event changes. Please see my comments for more details.

See also - https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

.github/workflows/jenkins-security-scan.yml Outdated Show resolved Hide resolved
.github/workflows/jenkins-security-scan.yml Show resolved Hide resolved
.github/workflows/jenkins-security-scan.yml Outdated Show resolved Hide resolved
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yahavi yahavi merged commit 8377109 into jfrog:main Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants