Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance JFrog CLI Credentials Input During Setup #101

Merged
merged 21 commits into from
Sep 19, 2024
Merged

Enhance JFrog CLI Credentials Input During Setup #101

merged 21 commits into from
Sep 19, 2024

Conversation

EyalDelarea
Copy link

@EyalDelarea EyalDelarea commented Sep 8, 2024 •
edited
Loading

Utilise the --password-stdin flag if supported CLI version is being used.

@EyalDelarea EyalDelarea marked this pull request as draft September 9, 2024 09:56
@EyalDelarea EyalDelarea added the improvement Automatically generated release notes label Sep 9, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@EyalDelarea EyalDelarea changed the title Use password-stdin Enhance jf c add command during setup Sep 9, 2024
@EyalDelarea EyalDelarea changed the title Enhance jf c add command during setup Enhance JFrog CLI Credentials Input During Setup Sep 9, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@EyalDelarea EyalDelarea marked this pull request as ready for review September 9, 2024 12:27
@EyalDelarea EyalDelarea marked this pull request as draft September 9, 2024 12:34
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@EyalDelarea EyalDelarea marked this pull request as ready for review September 12, 2024 08:01
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
yahavi
yahavi requested changes Sep 12, 2024
View reviewed changes
src/main/java/io/jenkins/plugins/jfrog/JfStep.java Outdated Show resolved Hide resolved
src/main/java/io/jenkins/plugins/jfrog/JfStep.java Outdated Show resolved Hide resolved
src/main/java/io/jenkins/plugins/jfrog/JfStep.java Outdated Show resolved Hide resolved
src/main/java/io/jenkins/plugins/jfrog/JfStep.java Outdated Show resolved Hide resolved
src/main/java/io/jenkins/plugins/jfrog/JfStep.java Outdated Show resolved Hide resolved
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 12, 2024
@RobiNino RobiNino merged commit 6f34090 into jfrog:main Sep 19, 2024
7 of 8 checks passed
@kaamos1 kaamos1 mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EyalDelarea @yahavi @RobiNino