Remove unsupported jf build step from freestyle projects #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
requested changes
Sep 9, 2024
| // JfStep Extends SimpleBuildStep, which applies also to FreeStyleProjects, as well as workflow jobs. | ||
| // To avoid errors due to unsupported inputs in FreeStyleProjects, | ||
| // Return applicable only for WorkflowJobProperty. | ||
| return WorkflowJobProperty.class.isAssignableFrom(jobType); |
There was a problem hiding this comment.
Shouldn't be this?
return WorkflowJob.class.isAssignableFrom(jobType) || WorkflowJob.class.isAssignableFrom(jobType);I haven't tested the solution.
Please also verify with Multibranch Pipelines.
There was a problem hiding this comment.
It's strange, but when i debug i'm getting an error thrown, also on the main branch when it comes to multi-branch.
On the other hand, when i installed the plugin on my local Jenkins, it doesn't crash.
Maybe it's related to the Jenkins version.
It needs to be tested.
…into hide_freestyle_project
|
This is causing the multi-branch pipeline to crash. |
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jf commands as a freestyle build step is not supported.
Remove to avoid confusion.