Support for multiple separators in the 'No proxy host' field: pipe (|), semicolon (;), newline, and comma (,) #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nathan770
changed the title
|
@Nathan770, |
yahavi
added
bug
github-actions
bot
removed
the
safe to test
yahavi
requested changes
Oct 7, 2024
Co-authored-by: Yahav Itschak <[email protected]>
Co-authored-by: Yahav Itschak <[email protected]>
added test
github-actions
bot
removed
the
safe to test
yahavi
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #106
The fix will update the no_proxy list by changing the separators from semicolons to commas, as required by the JFrog CLI.