Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance JFrog CLI Credentials Input During Setup #112

Closed
wants to merge 33 commits into from

Conversation

EyalDelarea
Copy link

@EyalDelarea EyalDelarea commented Nov 6, 2024

Utilise the --password-stdin flag if supported CLI version is being used.

When is it possible?

  1. CLI version supported.
  2. No custom launcher is used.

When a custom launcher is being used, the stdin we prepare in the plugin does not gets passed to the custom launchers, for example docker launchers.

@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 6, 2024
@EyalDelarea EyalDelarea changed the title Use password stdin when available Enhance JFrog CLI Credentials Input During Setup Nov 11, 2024
@EyalDelarea EyalDelarea added the improvement Automatically generated release notes label Nov 11, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@EyalDelarea EyalDelarea self-assigned this Nov 14, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@EyalDelarea
Copy link
Author

@yahavi i've updated the PR, let me know what you think.

@EyalDelarea
Copy link
Author

Moved this PR to #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants