Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support No-Proxy hosts with dash #97

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Support No-Proxy hosts with dash #97

merged 1 commit into from
Jul 21, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jul 19, 2024

Fix #93

Providing a no-proxy host with a dash character does not match any URL because the regex pattern [\\w.]+ only accepts letters, numbers, and underscores.

@yahavi yahavi added the bug Something isn't working label Jul 19, 2024
@yahavi yahavi requested review from eyalbe4 and RobiNino July 19, 2024 14:38
@yahavi yahavi self-assigned this Jul 19, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jul 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 19, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@yahavi yahavi merged commit b12a331 into jfrog:main Jul 21, 2024
9 checks passed
@yahavi yahavi deleted the dash-proxy branch July 21, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no_proxy fails with urls containing a dash
2 participants