Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to Artifactory Integration and NPM dependency tree building #1011

Merged
merged 11 commits into from
Oct 31, 2023
Merged

Enhancements to Artifactory Integration and NPM dependency tree building #1011

merged 11 commits into from
Oct 31, 2023

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Oct 26, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Summary of Changes:

Automatically collects and inserts details of the Artifactory server and resolve repository into Audit parameters (for future use in dependency tree construction). This adjustment applies to all flows that construct a dependency tree.

Enhances the building of NPM dependency trees to resolve dependencies from an Artifactory server when configured by the user.

Introduces new parameters within Audit parameters to allow users to provide customized installation commands for building dependency trees. Note that not all entry points support the provision of these parameters.

Depends on: jfrog/build-info-go#207

@eranturgeman eranturgeman temporarily deployed to frogbot October 26, 2023 10:19 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the improvement Automatically generated release notes label Oct 26, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot October 26, 2023 11:52 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot October 26, 2023 15:35 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot October 29, 2023 12:37 — with GitHub Actions Inactive
@eranturgeman eranturgeman mentioned this pull request Oct 29, 2023
Merged
3 tasks
eyalbe4
eyalbe4 requested changes Oct 30, 2023
View reviewed changes
xray/commands/audit/sca/npm/npm.go Outdated Show resolved Hide resolved
xray/commands/audit/sca/npm/npm.go Outdated Show resolved Hide resolved
xray/commands/audit/sca/npm/npm.go Outdated Show resolved Hide resolved
xray/commands/audit/sca/npm/npm.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman changed the title Npm - Enabling configuration of an Artifactory server and adding additional audit params Npm - Enabled configuring an Artifactory server + Additional audit params Oct 30, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot October 31, 2023 11:14 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot October 31, 2023 11:31 — with GitHub Actions Inactive
eyalbe4
eyalbe4 requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Let's just improve the grammar of the inline comments, PR title and PR description before merging.

@eranturgeman eranturgeman temporarily deployed to frogbot October 31, 2023 13:57 — with GitHub Actions Inactive
@eranturgeman eranturgeman changed the title Npm - Enabled configuring an Artifactory server + Additional audit params Enhancements to Artifactory Integration and Dependency Tree Building and Oct 31, 2023
@eranturgeman eranturgeman changed the title Enhancements to Artifactory Integration and Dependency Tree Building and Enhancements to Artifactory Integration and NPM dependency tree building Oct 31, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot October 31, 2023 14:40 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot October 31, 2023 14:51 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

@eranturgeman eranturgeman merged commit e2f7d85 into jfrog:dev Oct 31, 2023
8 checks passed
@eranturgeman eranturgeman mentioned this pull request Oct 31, 2023
Closed
4 tasks
@BrewTestBot BrewTestBot mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @eyalbe4