Package manager login command - Docker, Podman #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sverdlov93
commented
Nov 20, 2024
•
sverdlov93
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
- Added Docker and Podman to Package Manager login command
- Added projectKey filter support.
- Some small improvements for interactive quiestionire
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
…m-login # Conflicts: # artifactory/commands/python/python.go # artifactory/commands/python/utils_test.go # common/cliutils/utils.go
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
yahavi
reviewed
Dec 25, 2024
There was a problem hiding this comment.
@sverdlov93
Before I dive into the code, please add the following:
- Pull Request Description - It's essential to have a description as it helps me understand the author's intent. Comparing the description with the code allows me to identify potential bugs.
- Unit Tests - This pull request introduces non-trivial code, and it's difficult to ascertain its correctness without some basic tests in place.
Thanks! 🙏🏼
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
yahavi
requested changes
Dec 26, 2024
Comment on lines
+76
to
+78
| slices.SortFunc(allSupportedPackageManagers, func(a, b project.ProjectType) int { | ||
| return int(a) - int(b) | ||
| }) |
There was a problem hiding this comment.
Suggested change
| slices.SortFunc(allSupportedPackageManagers, func(a, b project.ProjectType) int { | |
| return int(a) - int(b) | |
| }) | |
| slices.Sort(allSupportedPackageManagers) |
Also - what is the reason for the sorting?
There was a problem hiding this comment.
to show the interactive list according to the order I prefer, npm near yarn, docker near podman and etc
@yahavi
Comment on lines
+72
to
+80
| // GetSupportedPackageManagersList returns a sorted list of supported package managers. | ||
| func GetSupportedPackageManagersList() []project.ProjectType { | ||
| allSupportedPackageManagers := maps.Keys(packageManagerToRepositoryPackageType) | ||
| // Sort keys based on their natural enum order | ||
| slices.SortFunc(allSupportedPackageManagers, func(a, b project.ProjectType) int { | ||
| return int(a) - int(b) | ||
| }) | ||
| return allSupportedPackageManagers | ||
| } |
There was a problem hiding this comment.
This code is unused in the jfrog-cli-core. Is this code intended to be used in other libraries?
There was a problem hiding this comment.
jfrog-cli @yahavi
artifactory/commands/packagemanagerlogin/packagemanagerlogin.go
Outdated
Show resolved
Hide resolved
artifactory/commands/packagemanagerlogin/packagemanagerlogin.go
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| func (projectType ProjectType) String() string { | ||
| return ProjectTypes[projectType] | ||
| } | ||
|
|
||
| // FromString converts a string to its corresponding ProjectType | ||
| func FromString(value string) ProjectType { |
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.