Catch errors from test cli gorutines through channel #1324

attiasas · 2024-12-31T13:25:28Z

All tests passed. If this feature is not already covered by the tests, I added new tests.
All static analysis checks passed.
This pull request is on the dev branch.
I used gofmt for formatting the code before submitting the pull request.

Add option to run test CLI with command that return error as well

utils/tests/test_cli.go

Test Cli outputs of cmd with errors

243cf93

attiasas requested a deployment to frogbot December 31, 2024 13:25 — with GitHub Actions Waiting

attiasas added the ignore for release Automatically generated release notes label Dec 31, 2024

attiasas requested review from eyalbe4, yahavi, EyalDelarea and sverdlov93 December 31, 2024 13:45

sverdlov93 reviewed Dec 31, 2024

View reviewed changes

utils/tests/test_cli.go Outdated Show resolved Hide resolved

sverdlov93 reviewed Dec 31, 2024

View reviewed changes

utils/tests/test_cli.go Show resolved Hide resolved

attiasas mentioned this pull request Dec 31, 2024

Fix and add tests for Jas Violations jfrog/jfrog-cli-security#273

Merged

7 tasks

use chanel to pass error value

145e516

attiasas requested a deployment to frogbot January 1, 2025 08:06 — with GitHub Actions Waiting

attiasas requested a review from sverdlov93 January 1, 2025 08:06

sverdlov93 approved these changes Jan 1, 2025

View reviewed changes

sverdlov93 merged commit b26e9a6 into jfrog:dev Jan 1, 2025
6 of 7 checks passed

sverdlov93 changed the title ~~Test Cli outputs of cmd with errors~~ Catch errors from test cli gorutines through channel Jan 1, 2025

Provide feedback