Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue in build scan result_url when JFrog URL is not configured #127

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Issue in build scan result_url when JFrog URL is not configured #127

merged 9 commits into from
Aug 6, 2024

Conversation

dortam888
Copy link
Contributor

@dortam888 dortam888 commented Aug 3, 2024 •
edited by attiasas
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Fixed an issue: when JFrog URL is not configured but ArtifactoryURL and XrayURL, the scan_url is returned wrongly.
See discussion in jfrog/jfrog-cli#2629

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Aug 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 5, 2024
attiasas
attiasas requested changes Aug 5, 2024
View reviewed changes
commands/scan/buildscan.go Outdated Show resolved Hide resolved
@dortam888 dortam888 added the safe to test Approve running integration tests on a pull request label Aug 6, 2024
@dortam888 dortam888 requested a review from attiasas August 6, 2024 08:01
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 6, 2024
attiasas
attiasas requested changes Aug 6, 2024
View reviewed changes
commands/scan/buildscan.go Outdated Show resolved Hide resolved
commands/scan/buildscan_test.go Outdated Show resolved Hide resolved
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

@attiasas attiasas merged commit aa27ff7 into jfrog:dev Aug 6, 2024
9 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dortam888 @attiasas