Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail 'jf scan' when a wrong flag is provided after command's arguments #165

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open
6 changes: 6 additions & 0 deletions cli/scancommands.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,13 @@ func EnrichCmd(c *components.Context) error {
func ScanCmd(c *components.Context) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does docker scan uses the same flow as ScanCmd? or should implement it there too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is using dockerCmd that resides in CLI. I initiated another PR to ecosystem:
jfrog/jfrog-cli#2686

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadarshjfrog Since resolving the same issue in 'jf docker scan' should be done by Ecosystem and this is not a top priority for them. Since this is not going to happen soon and I dont want to miss the fix Iv'e already worked on im proceeding without 'jf docker scan' and we can open a ticket for the Ecosystem about this

if len(c.Arguments) == 0 && !c.IsFlagSet(flags.SpecFlag) {
return pluginsCommon.PrintHelpAndReturnError("providing either a <source pattern> argument or the 'spec' option is mandatory", c)
} else if len(c.Arguments) > 1 {
// If a non-existing flag was provided AFTER the provided source_pattern - it will be captured as another argument. Since 'scan' command
// Expects only a single argument, we use this check to verify all provided flags are valid.
// If a non exiting flag was provided BEFORE the source_pattern, the CLI will return an error before reaching this point.
return pluginsCommon.PrintHelpAndReturnError(utils.GetCliTooManyArgsErrorMessage(len(c.Arguments)), c)
}

serverDetails, err := createServerDetailsWithConfigOffer(c)
if err != nil {
return err
Expand Down
7 changes: 7 additions & 0 deletions utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,10 @@ func splitEnvVar(envVar string) (key, value string) {
}
return split[0], strings.Join(split[1:], "=")
}

// This is a general error message for the CLI commands.
// Because of how command parsing is handled, improperly specified flags may be misinterpreted as arguments.
// Therefore, these flags will not go through the command's flags verifications, and will not be caught as incorrect flags.
func GetCliTooManyArgsErrorMessage(numberOfArguments int) string {
return fmt.Sprintf("Too many arguments provided (%d in total).\nSome flags may be incorrectly specified, causing them to be misinterpreted as arguments and ignored. Please verify that all flags are valid.", numberOfArguments)
eranturgeman marked this conversation as resolved.
Show resolved Hide resolved
eranturgeman marked this conversation as resolved.
Show resolved Hide resolved
}
Loading