-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail 'jf scan' when a wrong flag is provided after command's arguments #165
Open
eranturgeman
wants to merge
12
commits into
jfrog:dev
Choose a base branch
from
eranturgeman:fix-scan-ignored-flags-issue
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b73beff
Adding a warning for misidentified flags if the command was executed …
eranturgeman 4a880c0
refactor for cleaner code
eranturgeman 0fea4d8
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
eranturgeman b6ef48a
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
eranturgeman a9bf652
fixing error message and making the execution to fail in case the err…
eranturgeman 601bd0a
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
eranturgeman 01baf4c
.
eranturgeman 1451968
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
eranturgeman 84455f6
added partial test - complete it
eranturgeman 6ecc4ef
comment about test
eranturgeman 7c2782b
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
eranturgeman ea59b23
added test
eranturgeman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does docker scan uses the same flow as
ScanCmd
? or should implement it there too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is using dockerCmd that resides in CLI. I initiated another PR to ecosystem:
jfrog/jfrog-cli#2686
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hadarshjfrog Since resolving the same issue in 'jf docker scan' should be done by Ecosystem and this is not a top priority for them. Since this is not going to happen soon and I dont want to miss the fix Iv'e already worked on im proceeding without 'jf docker scan' and we can open a ticket for the Ecosystem about this