Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published scoped npm packages gets wrong path using JF CLI #2280

Open
elumalaigjfrog opened this issue Oct 23, 2023 · 6 comments · Fixed by jfrog/build-info-go#273
Open

Published scoped npm packages gets wrong path using JF CLI #2280

elumalaigjfrog opened this issue Oct 23, 2023 · 6 comments · Fixed by jfrog/build-info-go#273
Labels
bug Something isn't working

Comments

@elumalaigjfrog
Copy link

Describe the bug

I did create one scope package for testing and pushed two versions 1.0.0 and 2.0.0 to the local repo using both NPM and JF CLI respectively.
The customer has seen a difference in path when it comes to scoped packages when pushed with JF CLI 2.50.2.
#npm view @test/[email protected] dist.tarball
http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

npm view @test/[email protected] dist.tarball

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/scoped-test-2.0.0.tgz
I can view the difference in the path when it comes to scoped packages and not regular ones.

Current behavior

I did create one scope package for testing and pushed two versions 1.0.0 and 2.0.0 to the local repo using both NPM and JF CLI respectively.
The customer has seen a difference in path when it comes to scoped packages when pushed with JF CLI 2.50.2.
#npm view @test/[email protected] dist.tarball
http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

npm view @test/[email protected] dist.tarball

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/scoped-test-2.0.0.tgz
I can view the difference in the path when it comes to scoped packages and not regular ones.

Reproduction steps

Create a NPM scoped package
Use JF CLI to publish the package.

Expected behavior

#npm view @test/[email protected] dist.tarball - npm client
http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

npm view @test/[email protected] dist.tarball - JF CLI

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/scoped-test-2.0.0.tgz

I can view the difference in the path and it should be same.

JFrog CLI version

2.50.2

Operating system type and version

Mac

JFrog Artifactory version

No response

JFrog Xray version

No response

@elumalaigjfrog elumalaigjfrog added the bug Something isn't working label Oct 23, 2023
@niklas2810
Copy link

niklas2810 commented Oct 24, 2023

I could reproduce this and face the same issue. It is important to point out though that the npm install for the package published via JFrog CLI still works, but it's still an inconvenience.

@DiyanDev
Copy link

I was also able to replicate this, publishing using the native "npm publish" command results in duplicate scope in the path.

Same as the example @elumalaigjfrog provided:
//localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

That's not the case using jfrog-cli or the Artifactory plugin for Jenkins.

@pauloazevedo88
Copy link

Any update on this topic? Having the same issue with local npm publish:

https://my.artifactory/artifactory/my-releases//**@my-team**/other/-/**@my-team**/other-test-0.0.16.tgz

connyay added a commit to connyay/build-info-go that referenced this issue Sep 5, 2024
connyay added a commit to connyay/build-info-go that referenced this issue Sep 5, 2024
@joanna-polec
Copy link

Hi, I have also encountered the same issue. Waiting for this fix.

@wojtekkosowicz
Copy link

Hey, having the same issue. Hoping for the fix soon.

@connyay
Copy link

connyay commented Sep 16, 2024

👉 jfrog/build-info-go#273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants