Fix npm's deployment path

[connyay]

Fixes jfrog/jfrog-cli#2280

• All tests passed. If this feature is not already covered by the tests, I added new tests.
• All static analysis checks passed.
• This pull request is on the dev branch.
• I used gofmt for formatting the code before submitting the pull request.

---

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[connyay]

I have read the CLA Document and I hereby sign the CLA

[sverdlov93]

Hi @connyay, following the above fix do you think that the artifact name should also include the scope?

because currently its uploaded without it .
jfrog-cli-tests-=1.0.0.tgz > @scope/jfrog-cli-tests-=1.0.0.tgz

[sverdlov93]

Hi @connyay, following the above fix do you think that the artifact name should also include the scope? because currently its uploaded without it . jfrog-cli-tests-=1.0.0.tgz > @scope/jfrog-cli-tests-=1.0.0.tgz

@connyay

[connyay]

@sverdlov93 I am not sure. I don't think so.

This test case matches my expectations:

build-info-go/build/utils/npm_test.go

Line 102 in c694d21

{`@jfrog/build-info-go-tests/-/@jfrog/build-info-go-tests-1.0.0.tgz`, &PackageInfo{Name: "build-info-go-tests", Version: "1.0.0", Scope: "@jfrog"}},

From what I can tell this change will fix jfrog/jfrog-cli#2280

Is there a separate issue about the artifact name not having scope?

[sverdlov93]

Following your change, we have failing tests on JFrog CLI, so I am trying to understand how to handle that.
For example:
{
"name": "@my-scope/my-package",
"version": "1.0.0",
"description": "A sample scoped package",
}
The artifact name here should be @my-scope/my-package or my-package ?