Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve build-scan vuln flag handling and help section #1867

Merged
merged 7 commits into from
Mar 14, 2023
Merged

Improve build-scan vuln flag handling and help section #1867

merged 7 commits into from
Mar 14, 2023

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Mar 13, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

following jfrog/jfrog-cli-core#704

@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Mar 13, 2023
@sverdlov93 sverdlov93 changed the title Improve build-scan vuln flag Improve build-scan vuln flag handling Mar 13, 2023
@sverdlov93 sverdlov93 changed the title Improve build-scan vuln flag handling Improve build-scan vuln flag handling and help section Mar 13, 2023
@sverdlov93 sverdlov93 merged commit 7018b90 into jfrog:dev Mar 14, 2023
talarian1
talarian1 reviewed Mar 14, 2023
View reviewed changes
Copy link
Contributor

@talarian1 talarian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@p-linnane p-linnane mentioned this pull request Mar 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talarian1 talarian1 talarian1 left review comments

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @talarian1