Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add npm publish -workspaces test #2471

Merged
merged 11 commits into from
Mar 12, 2024
Merged

Add npm publish -workspaces test #2471

merged 11 commits into from
Mar 12, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Mar 11, 2024 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Add npm publish --workspaces test to verify both packages gets published.

depends on :
jfrog/jfrog-cli-core#1149

@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label Mar 11, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Mar 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 11, 2024
@EyalDelarea EyalDelarea marked this pull request as ready for review March 11, 2024 16:25
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Mar 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 11, 2024
sverdlov93
sverdlov93 reviewed Mar 11, 2024
View reviewed changes
npm_test.go Outdated Show resolved Hide resolved
sverdlov93
sverdlov93 reviewed Mar 11, 2024
View reviewed changes
npm_test.go Outdated Show resolved Hide resolved
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Mar 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 11, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Mar 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 12, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Mar 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 12, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Mar 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@EyalDelarea EyalDelarea merged commit 2f0e0c9 into jfrog:dev Mar 12, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EyalDelarea @sverdlov93