Sign MacOS Binaries with JFrog Certificate #2563
Open
+392
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyalDelarea
force-pushed
the
sign_apple_binary
branch
from
f8c06b3
to
4342c49
Compare
EyalDelarea
force-pushed
the
sign_apple_binary
branch
from
421e986
to
4342c49
Compare
EyalDelarea
commented
Jul 14, 2024
| local cooldown=15 # Cooldown in seconds between retries | ||
| local retry_count=0 | ||
|
|
||
| while [ $retry_count -lt $max_retries ]; do |
There was a problem hiding this comment.
@yahavi,
In here we can't use curl --retry, because the curl execution will be okay as it queries all the artifacts from the repo.
The retry is when the query doesn't return the specific version and release version executable, which we try to filter from the response.
yahavi
requested changes
Nov 20, 2024
| -H "Accept: application/vnd.github+json" \ | ||
| -H "Authorization: Bearer $GITHUB_ACCESS_TOKEN" \ | ||
| -H "X-GitHub-Api-Version: 2022-11-28" \ | ||
| -s https://api.github.com/repos/eyaldelarea/jfrog-cli/actions/artifacts) |
There was a problem hiding this comment.
Suggested change
| -s https://api.github.com/repos/eyaldelarea/jfrog-cli/actions/artifacts) | |
| -s https://api.github.com/repos/jfrog/jfrog-cli/actions/artifacts) |
| response=$(curl -L \ | ||
| -H "Accept: application/vnd.github+json" \ | ||
| -H "Authorization: Bearer $GITHUB_ACCESS_TOKEN" \ | ||
| -H "X-GitHub-Api-Version: 2022-11-28" \ |
There was a problem hiding this comment.
According to the documentation:
When a new REST API version is released, the previous API version will be supported for at least 24 more months following the release of the new API version.
Let's use the latest API
Comment on lines
3
to
8
| cliExecutableName=$1 | ||
| releaseVersion=$2 | ||
| goarch=$3 | ||
| GITHUB_ACCESS_TOKEN=$4 | ||
|
|
||
| # This script downloads signed macOS binaries for a specific version and architecture. |
There was a problem hiding this comment.
Suggested change
| cliExecutableName=$1 | |
| releaseVersion=$2 | |
| goarch=$3 | |
| GITHUB_ACCESS_TOKEN=$4 | |
| # This script downloads signed macOS binaries for a specific version and architecture. | |
| # Script Purpose: Download signed macOS binaries for a specific version and architecture. | |
| # The name of the CLI executable to be processed - jfrog or jf | |
| cliExecutableName=$1 | |
| # The version of the release being processed | |
| releaseVersion=$2 | |
| # The architecture of the macOS binary to be downloaded - amd64 or arm64 | |
| goarch=$3 | |
| # GitHub Access Token for authentication | |
| GITHUB_ACCESS_TOKEN=$4 |
| GITHUB_ACCESS_TOKEN=$3 # GitHub Access Token for authentication | ||
|
|
||
| # Trigger | ||
| curl -L \ |
| fi | ||
|
|
||
| # Download the artifact | ||
| curl -L \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....Sign Darwin Binaries during Release
This PR introduce a way to integrate darwin signed executables singing during the CLI release.
Darwin Release Flow:
flowchart TD A[Release Pipepline Triggers the MacOS specific workflow] --> B[GitHub Actions Build & Upload Signed darwin exeutables] --> C(Jenkins Job downloads the binary from Github packages) C --> E E[Distribute to releases]TODO Before merging: