Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle insecure-tls in all commands #875

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

fsamin
Copy link

@fsamin fsamin commented Oct 27, 2020

I wasn't able to run the access-token-create command with the --insecure-tls flag.
So I suggest to handle the insecure-tls in all commands. I confirm that the lower layers of the CLI handle it perfectly.

Signed-off-by: francois samin [email protected]

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2020

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@fsamin
Copy link
Author

fsamin commented Oct 27, 2020

I have read the CLA Document and I hereby sign the CLA

@eyalbe4
Copy link
Contributor

eyalbe4 commented Dec 13, 2020

@fsamin,
Thanks for creating this PR.
Just adding the --insecure-tls flag to those commands will not make it work. This is because the implementation does not use it. Unlike the mvn command, which translates this flag into maven equivalent maven options, gradle or the docker commands do not.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Mar 29, 2021

@fsamin,
Please let me know if you'd like to keep this PR open.

@fsamin
Copy link
Author

fsamin commented Mar 31, 2021

Hello,
Yes, please keep this open.
I have to rebase and check all the commands that can support --insecure-tls (i.e targeting Artifactory API) and the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants