Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New service for centralized config profile #1002

Merged
merged 17 commits into from
Aug 26, 2024
Merged

New service for centralized config profile #1002

merged 17 commits into from
Aug 26, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Aug 14, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This pull requests contains a new service for centralized config profile with a GET profile endpoint implementation.
Few changes to function names for ErrorReport service were added in order to align all xsc services.
Note: There is 1 TODO comment to switch to the actual minimal version of Xsc for this feature. This will be updated when this version will be released (before this PR is merged)

@eranturgeman eranturgeman added the new feature Automatically generated release notes label Aug 14, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2024
eyalbe4
eyalbe4 requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't yet reviewed this PR. I'll do so soon, but I've already noticed that you haven't yet added new API to the README. Go ahead and do so till I become available to review the PR.

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2024
eyalbe4
eyalbe4 requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's run go fmt ./... on the code.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/xscconfigprofile_test.go Outdated Show resolved Hide resolved
tests/xscconfigprofile_test.go Outdated Show resolved Hide resolved
tests/xscconfigprofile_test.go Outdated Show resolved Hide resolved
xsc/services/profile.go Outdated Show resolved Hide resolved
xsc/services/profile.go Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 18, 2024
@eranturgeman eranturgeman mentioned this pull request Aug 19, 2024
Merged
6 tasks
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 20, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 21, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 21, 2024
eyalbe4
eyalbe4 requested changes Aug 22, 2024
View reviewed changes
xsc/services/profile.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 25, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 25, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Aug 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 26, 2024
@eyalbe4 eyalbe4 merged commit 219b34f into jfrog:dev Aug 26, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @eyalbe4