Handle archive upload general progress bar counter incrementation #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/analysis.yml # go.mod # go.sum # utils/utils.go # xray/services/scan.go # xray/services/scan_test.go
# Conflicts: # utils/utils.go
…-errors # Conflicts: # go.sum
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
sverdlov93
had a problem deploying
to
frogbot
GitHub Actions
Failure
sverdlov93
added
the
safe to test
github-actions
bot
removed
the
safe to test
Signed-off-by: Michael Sverdlov <[email protected]>
yahavi
reviewed
Sep 12, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
sverdlov93
had a problem deploying
to
frogbot
GitHub Actions
Failure
Signed-off-by: Michael Sverdlov <[email protected]>
sverdlov93
had a problem deploying
to
frogbot
GitHub Actions
Failure
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
sverdlov93
had a problem deploying
to
frogbot
GitHub Actions
Failure
Signed-off-by: Michael Sverdlov <[email protected]>
sverdlov93
had a problem deploying
to
frogbot
GitHub Actions
Failure
sverdlov93
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
requested changes
Sep 14, 2024
artifactory/services/upload.go
Outdated
| // saveFilesPathsFunc (optional) is a func that is called for each file that is written into the ZIP, and gets the file's local path as a parameter. | ||
| func (us *UploadService) readFilesAsZip(archiveDataReader *content.ContentReader, progressPrefix string, flat, symlink bool, | ||
| func (us *UploadService) readFilesAsZip(archiveDataReader *content.ContentReader, isZipDryRun, flat, symlink bool, |
There was a problem hiding this comment.
isZipDryRun --> dryRun
In addition to removing the redundant "zip" section from the argument name, that is unnecessary beucase the function's content is already related to the zip, it's preferred to avoid adding the "is" prefix to boolean variables.
Let's change the argument's description as well.
There was a problem hiding this comment.
@eyalbe4 its on purpose. We already have a dryRun expression among JFrog CLI command so I didn't want to confuse with that known flag.
Do you have another idea?
Signed-off-by: Michael Sverdlov <[email protected]>
sverdlov93
had a problem deploying
to
frogbot
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, all files uploaded as part of an archive are counted for the total number of tasks (denominator), but the numerator are counted only at the end of the zip upload as 1 task.
So for 60k files it's 1/60000 till the end of the upload.
This PR fixes it.