Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass http.Client to all managers #1027

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

ahippler
Copy link

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Before this change only the artifactory manager applied the httpClient of the config builder.
Now all JfrogClientBuilder are in sync which caused some moved lines.

Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@ahippler
Copy link
Author

ahippler commented Sep 29, 2024

I have read the CLA Document and I hereby sign the CLA

@ahippler
Copy link
Author

recheck

@ahippler
Copy link
Author

@eyalbe4 could you please have a look?

@eyalbe4 eyalbe4 self-requested a review September 30, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant