Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username and description to access token commands #810

Closed
wants to merge 1 commit into from

Conversation

Mavrickk3
Copy link

@Mavrickk3 Mavrickk3 commented Aug 14, 2023

This PR contains the same changes as #759, just with updated readme to address the latest change requests: #759 (review)

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@github-actions
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@Mavrickk3
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@Mavrickk3
Copy link
Author

recheck

@eyalbe4 eyalbe4 self-requested a review August 31, 2023 11:18
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Aug 31, 2023
@eyalbe4 eyalbe4 changed the title add username and description to access token commands Add username and description to access token commands Aug 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 31, 2023
@eyalbe4
Copy link
Contributor

eyalbe4 commented Aug 31, 2023

recheck

@yahavi
Copy link
Member

yahavi commented Sep 3, 2023

@Mavrickk3
Thanks for your contribution!

Your code appears to be committed under the user @ngergely6, but you initiated this Pull Request using your own user. This situation is causing the CLA assistant to prevent us from proceeding with this PR.

To resolve this, please update your local Git user configuration and replace the commit with the @Mavrickk3 user. This should help us move forward with the PR smoothly.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Nov 22, 2023

@Mavrickk3,
With your permission, I'm closing this PR, since it seems to be a duplicate of #759. Feel free to reopen it if needed.

@eyalbe4 eyalbe4 closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants