Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup of xray ignore rules functionality and added get all by filter implementation #979

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

cleanup of xray ignore rules functionality and added get all by filter implementation #979

wants to merge 2 commits into from

Conversation

3choBoomer
Copy link

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Moving some functionality from #960
cleaning up some stuff from #967

  • Fixed issues with inline docs
  • Added minimum server version checks
  • revised return values to follow golang standards
  • revised return value of Get method to match documentation.
  • Implemented get all by filters functionality.

@3choBoomer
Copy link
Author

@dortam888
@attiasas
@eyalbe4
@yahavi
@RobiNino

@3choBoomer 3choBoomer mentioned this pull request Jul 22, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@3choBoomer