-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
improved makefile and added documentation (#105)
- Loading branch information
Showing
5 changed files
with
80 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
- [ ] All [tests](https://github.com/jfrog/jfrog-docker-desktop-extension#tests) passed. If this feature is not already covered by the tests, I added new tests. | ||
- [ ] This pull request is on the dev branch. | ||
- [ ] I used "yarn lint" for formatting the code before submitting the pull request. | ||
- [ ] Update [documentation](https://github.com/jfrog/documentation) about new features / new supported technologies | ||
--- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# Guidelines | ||
## Prerequisites | ||
Make sure you have these tools on your computer: | ||
- yarn 1.x.x | ||
- docker | ||
- docker for windows | ||
|
||
#### Make sure to run the all the "make" commands from the root directory of the project repository. | ||
|
||
### Adding Tests | ||
|
||
If the existing tests do not already cover your changes, please add tests. | ||
|
||
## Building and running the project locally | ||
To build and run the plugin, follow these steps: | ||
1. Clone the code from this git repository https://github.com/jfrog/jfrog-docker-desktop-extension | ||
2. Run this command to build the image locally: | ||
```bash | ||
make build-extension | ||
``` | ||
3. Run this command to install the extension on your docker desktop: | ||
|
||
```bash | ||
make install-extension | ||
``` | ||
4. Make sure the checkbox labeled "Allow only extensions distributed through Docker Marketplace" is unchecked: | ||
![Alt text](resources/screenshots/7.png) | ||
5. Go to "My Extensions" tab on docker desktop and press Open": | ||
![Alt text](resources/screenshots/8.png) | ||
You can now use the extension locally on your docker desktop! | ||
## Updating and debugging code | ||
- To update the extension to include new code run: | ||
```bash | ||
make update | ||
``` | ||
- To debug the code run: | ||
```bash | ||
make debug | ||
``` | ||
- To stop debugging run: | ||
```bash | ||
make stop-debug | ||
``` | ||
## Publishing | ||
To publish new code run this command: | ||
- Pushes the image with the latest tag: | ||
```bash | ||
make release | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.