Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm - Partial scan #367

Merged
merged 6 commits into from
Jul 5, 2023
Merged

npm - Partial scan #367

merged 6 commits into from
Jul 5, 2023

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Jul 4, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

This PR brings an enhancement to the scanning for npm projects. It now enables the scanning process even if there are issues with npm ls, such as peer dependencies (as mentioned in this GitHub issue: #191). The scanning process will do its best to display as much data as possible, from the provided npm ls output.

@Or-Geva Or-Geva temporarily deployed to frogbot July 4, 2023 19:26 — with GitHub Actions Inactive
@Or-Geva Or-Geva requested review from yahavi and attiasas July 4, 2023 19:26
@Or-Geva Or-Geva mentioned this pull request Jul 4, 2023
Closed
2 tasks
@Or-Geva Or-Geva added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jul 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

yahavi
yahavi requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative @Or-Geva! I liked the greedy approach.
Please consider my comments.

src/main/treeDataProviders/dependenciesTree/dependenciesRoot/npmTree.ts Outdated Show resolved Hide resolved
src/main/treeDataProviders/dependenciesTree/dependenciesRoot/npmTree.ts Outdated Show resolved Hide resolved
src/main/treeDataProviders/dependenciesTree/dependenciesRoot/npmTree.ts Outdated Show resolved Hide resolved
@Or-Geva Or-Geva force-pushed the partiallyNpmScan branch from 4524f54 to fca303f Compare July 5, 2023 08:04
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Jul 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 5, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Jul 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 5, 2023
@Or-Geva Or-Geva temporarily deployed to frogbot July 5, 2023 08:16 — with GitHub Actions Inactive
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Jul 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

@Or-Geva Or-Geva merged commit 72505d6 into jfrog:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 left review comments

@yahavi yahavi yahavi requested changes

@attiasas attiasas Awaiting requested review from attiasas

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Or-Geva @eyalbe4 @yahavi