Fix connection check (#205)

jfrog · Sep 4, 2024 · df9cbe0 · df9cbe0
1 parent 254dc2c
commit df9cbe0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/auto-build-publish-test.yml b/.github/workflows/auto-build-publish-test.yml
@@ -24,6 +24,8 @@ jobs:
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
 
       - name: Setup Go with cache
         uses: jfrog/.github/actions/install-go-with-cache@main

diff --git a/lib/cleanup.js b/lib/cleanup.js
@@ -158,7 +158,7 @@ function checkConnectionToArtifactory() {
         try {
             core.startGroup('Checking connection to JFrog Artifactory');
             const pingResult = yield utils_1.Utils.runCliAndGetOutput(['rt', 'ping']);
-            if (pingResult !== 'OK') {
+            if (pingResult.trim() !== 'OK') {
                 core.debug(`Ping result: ${pingResult}`);
                 core.warning('Could not connect to Artifactory. Skipping Build Info post tasks.');
                 return false;

diff --git a/src/cleanup.ts b/src/cleanup.ts
@@ -124,7 +124,7 @@ async function checkConnectionToArtifactory(): Promise<boolean> {
     try {
         core.startGroup('Checking connection to JFrog Artifactory');
         const pingResult: string = await Utils.runCliAndGetOutput(['rt', 'ping']);
-        if (pingResult !== 'OK') {
+        if (pingResult.trim() !== 'OK') {
             core.debug(`Ping result: ${pingResult}`);
             core.warning('Could not connect to Artifactory. Skipping Build Info post tasks.');
             return false;