-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting username/description during rotation #85
Conversation
243a735
to
90f1d02
Compare
90f1d02
to
5b6b456
Compare
path_config_rotate_test.go
Outdated
t.Fatal(err) | ||
} | ||
|
||
accTestEnv.RotatePathConfigWithDetails(t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built the acceptance tests structure based on HashiCorp example, which is fine as a starter but probably a little simplistic. Some of the other acceptance tests have multiple func calls to setup, test, then cleanup. Ideal, I believe, is to make these funcs composable so you can mix and match as necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g.
t.Run("update", accTestEnv.UpdatePathConfig)
t.Run("read", accTestEnv.ReadPathConfig)
t.Run("rotate with details", accTestEnv.RotatePathConfigWithDetails) // New func
t.Run("read with details", accTestEnv.ReadPathConfigWithDetails) // New func
the token ID is now queryable with /config/admin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good. PR still in 'draft' mode so I assume it's not ready to be reviewed/approved yet. LMK.
Ooops, docs (README) would be good. :) DONE. take a look and let me know if any changes are needed. Thanks, |
This simply allows the optional setting of a username and/or description when rotating the admin token.
It still needs docs and tests.
Basic functionality:
NOTE: The token description is stored in the database, but is not in the actual JWT token.
/closes #69