Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter queries using bracket notation #16

Merged
merged 4 commits into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ruby-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.3.6
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Fix normalized string representations of node locations as returned by `JSONPathNode.path`.
- Fix canonical string representations of instances of `JSONPath`, as returned by `to_s`.
- Fixed filter queries with multiple bracketed segments. Previously we were failing to tokenize queries like `$[?@[0][0]]`. See [#15](https://github.com/jg-rp/ruby-json-p3/issues/15).

## [0.3.1] - 2024-12-05

Expand Down
2 changes: 0 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ gem "rubocop", "~> 1.21"

gem "steep", "~> 1.8"

gem "yard", "~> 0.9.37"

gem "minitest-fail-fast", "~> 0.1.0"

gem "stackprof", "~> 0.2.26"
Expand Down
4 changes: 1 addition & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ GEM
concurrent-ruby (~> 1.0)
unicode-display_width (2.6.0)
uri (1.0.2)
yard (0.9.37)

PLATFORMS
ruby
Expand All @@ -132,7 +131,6 @@ DEPENDENCIES
rubocop-rake (~> 0.6.0)
stackprof (~> 0.2.26)
steep (~> 1.8)
yard (~> 0.9.37)

BUNDLED WITH
2.5.17
2.6.3
2 changes: 1 addition & 1 deletion lib/json_p3/lexer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def lex_inside_bracketed_segment
case c
when "]"
emit(:token_rbracket, "]")
return @filter_depth.positive? ? :lex_inside_filter : :lex_segment
return :lex_segment
when ""
error "unclosed bracketed selection"
return nil
Expand Down
79 changes: 79 additions & 0 deletions test/test_lexer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,85 @@
Token.new(:token_name, "foo", 2, "$.foo.&"),
Token.new(:token_error, "&", 6, "$.foo.&", message: "unexpected shorthand selector '&'")
]
},
{
name: "relative query, bracket notation",
query: "$[?(@[0][0])]",
want: [
Token.new(:token_root, "$", 0, "$[?(@[0][0])]"),
Token.new(:token_lbracket, "[", 1, "$[?(@[0][0])]"),
Token.new(:token_filter, "?", 2, "$[?(@[0][0])]"),
Token.new(:token_lparen, "(", 3, "$[?(@[0][0])]"),
Token.new(:token_current, "@", 4, "$[?(@[0][0])]"),
Token.new(:token_lbracket, "[", 5, "$[?(@[0][0])]"),
Token.new(:token_index, "0", 6, "$[?(@[0][0])]"),
Token.new(:token_rbracket, "]", 7, "$[?(@[0][0])]"),
Token.new(:token_lbracket, "[", 8, "$[?(@[0][0])]"),
Token.new(:token_index, "0", 9, "$[?(@[0][0])]"),
Token.new(:token_rbracket, "]", 10, "$[?(@[0][0])]"),
Token.new(:token_rparen, ")", 11, "$[?(@[0][0])]"),
Token.new(:token_rbracket, "]", 12, "$[?(@[0][0])]"),
Token.new(:token_eoi, "", 13, "$[?(@[0][0])]")
]
},
{
name: "relative query, more bracket notation",
query: "$[?(@[0][0][1])]",
want: [
Token.new(:token_root, "$", 0, "$[?(@[0][0][1])]"),
Token.new(:token_lbracket, "[", 1, "$[?(@[0][0][1])]"),
Token.new(:token_filter, "?", 2, "$[?(@[0][0][1])]"),
Token.new(:token_lparen, "(", 3, "$[?(@[0][0][1])]"),
Token.new(:token_current, "@", 4, "$[?(@[0][0][1])]"),
Token.new(:token_lbracket, "[", 5, "$[?(@[0][0][1])]"),
Token.new(:token_index, "0", 6, "$[?(@[0][0][1])]"),
Token.new(:token_rbracket, "]", 7, "$[?(@[0][0][1])]"),
Token.new(:token_lbracket, "[", 8, "$[?(@[0][0][1])]"),
Token.new(:token_index, "0", 9, "$[?(@[0][0][1])]"),
Token.new(:token_rbracket, "]", 10, "$[?(@[0][0][1])]"),
Token.new(:token_lbracket, "[", 11, "$[?(@[0][0][1])]"),
Token.new(:token_index, "1", 12, "$[?(@[0][0][1])]"),
Token.new(:token_rbracket, "]", 13, "$[?(@[0][0][1])]"),
Token.new(:token_rparen, ")", 14, "$[?(@[0][0][1])]"),
Token.new(:token_rbracket, "]", 15, "$[?(@[0][0][1])]"),
Token.new(:token_eoi, "", 16, "$[?(@[0][0][1])]")
]
},
{
name: "relative query, bracket and dot notation",
query: "$[?(@[0].foo)]",
want: [
Token.new(:token_root, "$", 0, "$[?(@[0].foo)]"),
Token.new(:token_lbracket, "[", 1, "$[?(@[0].foo)]"),
Token.new(:token_filter, "?", 2, "$[?(@[0].foo)]"),
Token.new(:token_lparen, "(", 3, "$[?(@[0].foo)]"),
Token.new(:token_current, "@", 4, "$[?(@[0].foo)]"),
Token.new(:token_lbracket, "[", 5, "$[?(@[0].foo)]"),
Token.new(:token_index, "0", 6, "$[?(@[0].foo)]"),
Token.new(:token_rbracket, "]", 7, "$[?(@[0].foo)]"),
Token.new(:token_name, "foo", 9, "$[?(@[0].foo)]"),
Token.new(:token_rparen, ")", 12, "$[?(@[0].foo)]"),
Token.new(:token_rbracket, "]", 13, "$[?(@[0].foo)]"),
Token.new(:token_eoi, "", 14, "$[?(@[0].foo)]")
]
},
{
name: "relative query, dot and bracket notation",
query: "$[?(@.foo[0])]",
want: [
Token.new(:token_root, "$", 0, "$[?(@.foo[0])]"),
Token.new(:token_lbracket, "[", 1, "$[?(@.foo[0])]"),
Token.new(:token_filter, "?", 2, "$[?(@.foo[0])]"),
Token.new(:token_lparen, "(", 3, "$[?(@.foo[0])]"),
Token.new(:token_current, "@", 4, "$[?(@.foo[0])]"),
Token.new(:token_name, "foo", 6, "$[?(@.foo[0])]"),
Token.new(:token_lbracket, "[", 9, "$[?(@.foo[0])]"),
Token.new(:token_index, "0", 10, "$[?(@.foo[0])]"),
Token.new(:token_rbracket, "]", 11, "$[?(@.foo[0])]"),
Token.new(:token_rparen, ")", 12, "$[?(@.foo[0])]"),
Token.new(:token_rbracket, "]", 13, "$[?(@.foo[0])]"),
Token.new(:token_eoi, "", 14, "$[?(@.foo[0])]")
]
}
].freeze

Expand Down