-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A react native testing library test for the UI #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th a warning, fixed in a8ac8b62d4ed2dfc8522627f8edc443bcfdd43fc.
…sn't do anything.
…nd failing). Try to stop this by setting base-coverage-file too.
This reverts commit 5717046.
…atest release on github, but there's only v1 in the github action marketplace.
…mably stop tests being run when merge back to master?
… I don't want to stop running tests on merging back to master. Would also need to tune what it reports, since it doesn't give much info in the comment.
src/__tests__/nodeVersion.tsx:5:33 - error TS2339: Property 'version' does not exist on type 'typeof process'. Didn't get this error on CI, it's not clear why not.
jest test passes locally, but not on CI:
|
Now, jest times out instead:
|
|
Tests were failing since mock didn't allow for variation in the number of renders before changing from old to new data. Now it only changes the data after the assertions for the first data have passed. |
…t to allow empty set of components. Don't need waitFor in last test. Last test is still giving an act() warning...
…se act(). Fix by moving fingerprint Promise before render(). Same error comes back if add any trivial await after the render() and don't use act(). E.g. a promise that resolves after a 1s setTimeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://callstack.github.io/react-native-testing-library/docs/api