Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-wait on initalLoader #34

Merged
merged 1 commit into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/InitialLoader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const LoaderSubtext = styled('span')(({ theme }) => ({

const InitialLoader = ({ message }: { message?: string }) => {
return (
<LoaderWrapDiv>
<LoaderWrapDiv aria-busy="true">
{!message ? null : (
<Button
variant="outlined"
Expand Down
1 change: 0 additions & 1 deletion tests/screenshots.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ test('screenshot pages', async ({ page }, workerInfo) => {
for (const { name, path } of pages) {
const browserName = workerInfo.project.name
await page.goto(`${baseUrl}${path}`)
await page.waitForTimeout(3000) // wait for loader screen
await argosScreenshot(page, `${name}-${browserName}`)
}
})
Loading