Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #10349

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix typos #10349

merged 2 commits into from
Nov 6, 2024

Conversation

deining
Copy link
Contributor

@deining deining commented Nov 3, 2024

This PR fixes a few typos I spotted in the project.

@jgm
Copy link
Owner

jgm commented Nov 4, 2024

Thanks! Looks like the reflowing changed in one of the test files, this should be easy to fix.
https://github.com/jgm/pandoc/actions/runs/11654732857/job/32448590526?pr=10349#step:9:4251

@deining deining marked this pull request as ready for review November 6, 2024 07:45
@deining
Copy link
Contributor Author

deining commented Nov 6, 2024

Thanks!

You are welcome!

Looks like the reflowing changed in one of the test files,
this should be easy to fix.

I had a short glimpse at it, but wasn't able to resolve that issue immediately.
@jgm: Can you step in please? I'm not familiar with the project internals at all, so feel free to take this task over. Adding another commit that resolves the issue is highly appreciated!

@jgm
Copy link
Owner

jgm commented Nov 6, 2024

Easiest way to fix it is:

make TESTARGS=--accept

Then git diff to make sure the changes look right.

@jgm
Copy link
Owner

jgm commented Nov 6, 2024

I edited the file right in GH, let's see if it checks now.

@jgm jgm merged commit eeb8b1e into jgm:main Nov 6, 2024
8 of 12 checks passed
@jgm
Copy link
Owner

jgm commented Nov 6, 2024

Merged, thank you!

@deining deining deleted the fix-typos branch November 6, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants