-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make suppress-bibliography work with --biblatex #9131
base: main
Are you sure you want to change the base?
Conversation
Looks like this would only affect |
The conditional encompasses the two versions, it opens on line 556 and closes on line 588. I've tested it and seems to work. For the CI, from what I understand there are some failure because my changes introduce some new extra blank lines, right? |
OK, that helps. The template's structure is hard to see -- I've added some tabs to help myself:
If I understand correctly, you're adding a conditional that omits this whole section when My understanding was that in natbib, On the test suite: yes, if your changes introduced blank lines, then either you should modify the template or the test suite accordingly.
to
I know there's some fancy stuff in doctemplates regarding blank lines, but I don't recall the details. |
Right.
I had the impression that it works, but I have to run more extensive tests to be sure. I'll do that and do accordingly. (I am not used to natbib so I have to be more careful I guess.)
Ok I'll do that. |
I did some tests with natbib. The point would be to allow the user to print the bibliography at the place she wants. Yet the TeX result would be valid (would compile) only if the user has issued a So currently (I am waiting for CI reports) I implement only suppress-bibliography for --biblatex where it is very useful, for instance to issue manually one or several |
There may be a way to make it work with natbib too. |
But if you don't provide I'm okay with just implementing this for biblatex, though, if getting it to work with natbib is too complex. |
Now I see one possible solution for natbib:
If this makes sense, I can implement it. Not sure it's worth it though. |
That would be the intended behavior, yes, but the question we're asking is how is this to be implemented? That is, what will |
I don't see the problem since, as pandoc user's guide states, the |
That's right, but using |
Currently, setting the metadata variable suppress-bibliography has no effect with --biblatex nor --natbib. I add a simple conditional to make it work.