Add support for AzureDefaultCredential-based auth #178
Conversation
| @@ -50,18 +50,15 @@ public class AZURE_PINGDiscoveryTest { | |||
| public void testProtocolStack() throws Exception { | |||
| JChannel channel = new JChannel(STACK_XML_CONFIGURATION); | |||
|
|
|||
| channel.getProtocolStack().getProtocols().replaceAll(protocol -> { | |||
There was a problem hiding this comment.
Just an automatic conversion that my IDE performed to use "try-with-resources".
| @@ -63,7 +63,7 @@ | |||
|
|
|||
| <properties> | |||
| <version.org.jgroups>5.3.6.Final</version.org.jgroups> | |||
| <version.com.microsoft.azure.azure-storage>8.6.6</version.com.microsoft.azure.azure-storage> | |||
| <version.com.azure-azure-sdk-bom>1.2.23</version.com.azure-azure-sdk-bom> | |||
|
|
|||
| <!-- Overridden versions as managed by WildFly --> | |||
There was a problem hiding this comment.
I did not check if the updated Azure SDK components still cause issues here or (worse) in other parts of the dependency tree....
|
Upon a brief look the changes look pretty good to me! Excellent work. So what I think I will do, is that I ll move to new major branch as this bumps the SDK, pull your changes in, polish and test. |
|
Any updates regarding the integration of the changes? Can we support you somehow @rhusar ? :) |
Sorry for the delays on this, will prioritize this again. Let me try this week. Of course, would then appreciate some pre-testing - I will ping. |
Unfortunately, this PR contains a lot more changes than initially intended.
Seems like the coordinates of the Azure Storage Client library have changed and the API of the implementation was completely overhauled as well.
I took the time to try and adhere to current best practices when working with the Azure SDK for Java, e.g. utilizing the bills-of-material (BOM) dependency to make sure that all Azure-related libraries fit together, nicely.
I did not (yet) test the new library in my Cloud environment, but wanted to get this drafted PR out of the door as soon as possible to gather some feedback from the original maintainer.
@rhusar
Closes: #177