Async snapshot by working thread of RAFT #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabolina
requested changes
Sep 29, 2024
| takeSnapshot(); sr.f.complete(null); | ||
| } catch (Exception e) { | ||
| sr.f.completeExceptionally(e); | ||
| throw e; |
There was a problem hiding this comment.
There is no need to rethrow this exception. It will run from a single thread and would discard the batch of messages.
There was a problem hiding this comment.
It's in a Throwable try catch block, it can't affect other messages of the batch, and I think the exception is a internal error of the state machine it‘s worth printing out.
|
Sorry commit to a wrong branch |
jabolina
approved these changes
Oct 2, 2024
|
Thanks, @yfei-z! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #300, and a little change related to #308, I think DownRequests should failed directly if there is no space in the processing queue, let the caller to decide to retry or not, and this also meets the expectations of #168 which DownRequests has lower priority than UpRequests. And another thing is to make
setAsyncuninterruptible (no blocking operation), it helps StateMachine to implement uninterruptible interface.ArrayBlockingQueue.putchecks the interrupted status first, that means if the thread is interrupted before callingArrayBlockingQueue.putthen InterruptedException will be thrown even there is space available in the queue, so the outer method needs to check if there is an InterruptedException in the returned future and retry to make it uninterruptible, actually I think the IllegalStateException could be exposed directly while the processing queue is full.