Fixed bug where ButterKnife would not be used in the AboutActivity.

jguerinet · Jan 12, 2016 · ab747c1 · ab747c1
1 parent 5e060b5
commit ab747c1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/app/app.iml b/app/app.iml
@@ -125,8 +125,8 @@
     <orderEntry type="library" exported="" name="support-v4-23.1.1" level="project" />
     <orderEntry type="library" exported="" name="play-services-analytics-8.3.0" level="project" />
     <orderEntry type="library" exported="" name="form-generator-2.1.3" level="project" />
-    <orderEntry type="library" exported="" name="bolts-android-1.2.1" level="project" />
     <orderEntry type="library" exported="" name="support-annotations-23.1.1" level="project" />
+    <orderEntry type="library" exported="" name="bolts-android-1.2.1" level="project" />
     <orderEntry type="library" exported="" name="appcompat-v7-23.1.1" level="project" />
     <orderEntry type="library" exported="" name="instabugsupport-1.7.3" level="project" />
     <orderEntry type="library" exported="" name="fabric-1.3.10" level="project" />

diff --git a/app/src/main/java/ca/appvelopers/mcgillmobile/ui/settings/AboutActivity.java b/app/src/main/java/ca/appvelopers/mcgillmobile/ui/settings/AboutActivity.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2014-2015 Appvelopers
+ * Copyright 2014-2016 Appvelopers
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -46,6 +46,11 @@
  * @since 1.0.0
  */
 public class AboutActivity extends BaseActivity {
+    /**
+     * The list view
+     */
+    @Bind(android.R.id.list)
+    protected RecyclerView mList;
     /**
      * The list of people
      */
@@ -54,9 +59,9 @@ public class AboutActivity extends BaseActivity {
     public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setContentView(R.layout.activity_about);
-        Analytics.getInstance().sendScreen("About");
-
+        ButterKnife.bind(this);
         setUpToolbar(true);
+        Analytics.getInstance().sendScreen("About");
 
         mPeople = new ArrayList<>();
         //Adnan
@@ -117,9 +122,8 @@ public void onCreate(Bundle savedInstanceState) {
                 getString(R.string.about_yulric_linkedin), getString(R.string.about_yulric_email)));
 
         //Set up the list
-        RecyclerView listView = (RecyclerView)findViewById(android.R.id.list);
-        listView.setLayoutManager(new LinearLayoutManager(this));
-        listView.setAdapter(new PersonAdapter());
+        mList.setLayoutManager(new LinearLayoutManager(this));
+        mList.setAdapter(new PersonAdapter());
     }
 
     /**