-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for disabling few website features #1597
base: master
Are you sure you want to change the base?
Conversation
Hey @jhaals! What do you think about those changes? For our deployment we need to be able to disable the "one-click" link - thus this PR would also fix me use case :). Best regards |
Hey @jhaals! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and sorry for the delay, I have been away on parental leave so these things have been put on hold. I think this make sense, would you or someone else interested in this feature be so kind and change the name of the environment variables to start with YOPASS_ instead of REACT_APP(I should update the other too but that will be breaking).
website/README.md
Outdated
- `REACT_APP_DISABLE_FEATURES_CARDS=1` - Allows disabling Features cards | ||
- `REACT_APP_DISABLE_ONE_CLICK_LINK=1` - Allows disabling "One-click link" support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `REACT_APP_DISABLE_FEATURES_CARDS=1` - Allows disabling Features cards | |
- `REACT_APP_DISABLE_ONE_CLICK_LINK=1` - Allows disabling "One-click link" support | |
- `YOPASS_DISABLE_FEATURES_CARDS=1` - Allows disabling Features cards | |
- `YOPASS_DISABLE_ONE_CLICK_LINK=1` - Allows disabling "One-click link" support |
- Toggle for Features cards - Toggle for "One-click link"
|
Thanks 👏 |
@Neverous just a small think left to fix.
|
This adds build time toggles for disabling: