fix file download problem with a urls which includes a port huydx#9

jhezjkp · Aug 13, 2016 · 41aac29 · 41aac29
1 parent 03213a9
commit 41aac29
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/http.go b/http.go
@@ -43,9 +43,14 @@ func NewHttpDownloader(url string, par int, skipTls bool) *HttpDownloader {
 	var resumable = true
 
 	parsed, err := stdurl.Parse(url)
+	var host = parsed.Host
+	var portIndex = strings.Index(host, ":")
+	if portIndex >= 0 {
+		host = host[0:portIndex]
+	}
 	FatalCheck(err)
 
-	ips, err := net.LookupIP(parsed.Host)
+	ips, err := net.LookupIP(host)
 	FatalCheck(err)
 
 	ipstr := FilterIPV4(ips)

diff --git a/http_test.go b/http_test.go
@@ -25,3 +25,10 @@ func TestPartCalculate(t *testing.T) {
 		t.Fatalf("part range was wrong")
 	}
 }
+
+func TestNewHttpDownloader(t *testing.T) {
+	displayProgress = false
+
+	NewHttpDownloader("http://www.golangtc.com:80/static/go/1.7rc6/go1.7rc6.darwin-amd64.pkg", 1, true)
+	NewHttpDownloader("http://www.golangtc.com/static/go/1.7rc6/go1.7rc6.darwin-amd64.pkg", 1, true)
+}