Merge pull request PelicanPlatform#1598 from turetske/ls-l-flag-switch

Switched the 'ls -L' and the logging '-l' flags
jhiemstrawisc · Sep 24, 2024 · 779ab97 · 779ab97
2 parents dbf5438 + b1eb92e
commit 779ab97
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 16 deletions.
diff --git a/cmd/object_ls.go b/cmd/object_ls.go
@@ -45,18 +45,12 @@ var (
 func init() {
 	flagSet := lsCmd.Flags()
 	flagSet.StringP("token", "t", "", "Token file to use for transfer")
-	flagSet.BoolP("long", "L", false, "Include extended information - The '-L' for long output will be changed to '-l' in the 7.11.0 pelican release")
+	flagSet.BoolP("long", "l", false, "Include extended information")
 	flagSet.BoolP("collectionOnly", "C", false, "List collections only")
 	flagSet.BoolP("objectonly", "O", false, "List objects only")
 	flagSet.BoolP("json", "j", false, "Print results in JSON format")
 
 	objectCmd.AddCommand(lsCmd)
-
-	lsCmd.PersistentPreRun = func(cmd *cobra.Command, args []string) {
-		if cmd.Flags().Changed("long") {
-			log.Warningln("The '-L' for long output will be changed to '-l' in the 7.11.0 pelican release")
-		}
-	}
 }
 
 func listMain(cmd *cobra.Command, args []string) error {

diff --git a/cmd/root.go b/cmd/root.go
@@ -147,7 +147,7 @@ func init() {
 		panic(err)
 	}
 
-	rootCmd.PersistentFlags().StringP("log", "l", "", "Specified log output file - The '-l' for logging will be changed to '-L' in the 7.11.0 pelican release")
+	rootCmd.PersistentFlags().StringP("log", "L", "", "Specified log output file")
 	if err := viper.BindPFlag("Logging.LogLocation", rootCmd.PersistentFlags().Lookup("log")); err != nil {
 		panic(err)
 	}
@@ -169,10 +169,4 @@ func init() {
 	if err := viper.BindPFlag("Server.WebPort", portFlag); err != nil {
 		panic(err)
 	}
-
-	rootCmd.PersistentPreRun = func(cmd *cobra.Command, args []string) {
-		if cmd.Flags().Changed("log") {
-			log.Warningln("The '-l' for logging will be changed to '-L' in the 7.11.0 pelican release")
-		}
-	}
 }
diff --git a/github_scripts/get_put_test.sh b/github_scripts/get_put_test.sh
@@ -123,7 +123,7 @@ do
 done
 
 # Run pelican object put
-./pelican object put ./get_put_tmp/input.txt pelican://$HOSTNAME:8444/test/input.txt -d -t get_put_tmp/test-token.jwt -l get_put_tmp/putOutput.txt
+./pelican object put ./get_put_tmp/input.txt pelican://$HOSTNAME:8444/test/input.txt -d -t get_put_tmp/test-token.jwt -L get_put_tmp/putOutput.txt
 
 # Check output of command
 if grep -q "Dumping response: HTTP/1.1 200 OK" get_put_tmp/putOutput.txt; then
@@ -134,7 +134,7 @@ else
     exit 1
 fi
 
-./pelican object get pelican://$HOSTNAME:8444/test/input.txt get_put_tmp/output.txt -d -t get_put_tmp/test-token.jwt -l get_put_tmp/getOutput.txt
+./pelican object get pelican://$HOSTNAME:8444/test/input.txt get_put_tmp/output.txt -d -t get_put_tmp/test-token.jwt -L get_put_tmp/getOutput.txt
 
 # Check output of command
 if grep -q "HTTP Transfer was successful" get_put_tmp/getOutput.txt; then