-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not read user password from DB closes #232 #233
Conversation
I see that you have disabled encryption on typeORM. So we have to find an alternative way to obscure that value. Therefore the PR is not complete. |
@amanganiello90 the change does not mean that the encryption is disabled. The change just means that whenever the user is read from the database, the password column is not included in the query. The password is still encrypted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to fix user e2e test on
generator-jhipster-nodejs/generators/server/templates/server/e2e/user.e2e-spec.ts.ejs
Line 29 in 058b1da
password: 'userTestLogin' |
The test integration pipeline fails for that.
@amanganiello90 thank you for pointing out and apologies for not running them before submitting the PR! Is there any way to run the full pipeline on a local machine? |
Hi @glutengo, you have to follows the steps of the integration-test yml files: https://github.com/jhipster/generator-jhipster-nodejs/tree/main/.github/workflows They use the templates defined in https://github.com/jhipster/generator-jhipster-nodejs/tree/main/test-integration/samples . The configuration are performed by .sh files in the upper folder. |
@amanganiello90 should be good now, pipeline checks have passed |
No description provided.