Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Quarkus Zalando problem #120

Closed
wants to merge 1 commit into from
Closed

Integrating Quarkus Zalando problem #120

wants to merge 1 commit into from

Conversation

danielpetisme
Copy link
Member

The spring generator relies on Zalando problem library to produce machine friendly HTTP response.
This PR aims to align Quarkus to this API contract.

The PR relies on https://github.com/cloudstark/quarkus-zalando-problem-extension

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@danielpetisme
Copy link
Member Author

The main concern is the activity of the https://github.com/cloudstark/quarkus-zalando-problem-extension project

To be honest I asked to the library if they plan to still maintain it: cloudstark/quarkus-zalando-problem-extension#91

If they don't want to maintain it what would be the options?

  • Develop a Zalando problem extension under the JHipster organisation (quarkus does not want to host and maintain 3rd party extensions anymore, it's way to much work for them)?
  • try to just cover the Jhipster part. IMHO, it's a dozen of exception, 401/403, constraints validations and couple of custom Jhipster exceptions.

WDYT @avdev4j @joewhite101 ?

@avdev4j
Copy link
Contributor

avdev4j commented Nov 25, 2020

Hi @danielpetisme
Indeed the project seems not to be maintained anymore. Do you think there is many things to do? (maintenance, improvements...).

I don't understand your second proposition but I think if we could have an extension under the JHipster organisation it will be awesome for visibility. Maybe it's a way to reach easily developers

@danielpetisme
Copy link
Member Author

The second option is to embed the serialization of jhipster exceptions to the same json structure Zalando Problem proposes. This would integrate nicely to the front (it's the beauty of API).

Basically it means implementing customs ExceptionMappers.

@SchulteMarkus
Copy link

SchulteMarkus commented Nov 30, 2020

Hi @danielpetisme
Indeed the project seems not to be maintained anymore. Do you think there is many things to do? (maintenance, improvements...).

I don't understand your second proposition but I think if we could have an extension under the JHipster organisation it will be awesome for visibility. Maybe it's a way to reach easily developers

I had been committer to https://github.com/cloudstark/quarkus-zalando-problem-extension for some time. I am pretty sure the project is dead for time being, the project owner is unreachable, see cloudstark/quarkus-zalando-problem-extension#91
Last time I visited the project there was not much left to do releasing a beta version in my opinion, see https://github.com/cloudstark/quarkus-zalando-problem-extension/issues . In my opinion, there is only one issue "get to extension up to date to latest Quarkus" missing.

@danielpetisme
Copy link
Member Author

Thanks @SchulteMarkus for your feedback!
We're considering taking over/reset the project, who knows maybe you'll be ready to help us 😉

@SchulteMarkus
Copy link

Thanks @SchulteMarkus for your feedback!
We're considering taking over/reset the project, who knows maybe you'll be ready to help us wink

To be honest, I am low on time. Maybe during the Christmas holidays, but I can't promise.

@danielpetisme
Copy link
Member Author

I take the opportunity to thank you for what you have done!

@danielpetisme
Copy link
Member Author

Since the quarkus-zalando-lib is not maintained I'm closing the issue to propose a new solution.

@danielpetisme danielpetisme deleted the machine-friendly-exception branch December 3, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants